fix #115 for mysql 8.4.0 #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krowinski
requested changes
May 8, 2024
There was a problem hiding this comment.
hi tx for contribution
1, Fix tests
- MySQLReplication\Tests\Unit\Repository\MySQLRepositoryTest::testShouldGetVersion
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'foobar123'
+''
run composer cs:fix to fix code style
|
Any status of this PR or is there some other php 8.4 fixes in the works? |
My project used this pr in product env. |
…deprecated, the explicit nullable type must be used instead
|
@krowinski now with more mysql versions in test suite, maybe this has a chance to be tested and (maybe) merged? |
|
@cyppe resolve conflict pls |
krowinski
requested changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.